-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split CMake identities: superproject and 'developer' #392
base: develop
Are you sure you want to change the base?
Conversation
This is still somewhat broken, I haven't got the tests to compile properly yet, I think it's partly missing the required Boost.UTF macros, but also some unexpected |
I actually don't know who else works on Boost.Graph and prefers CMake, so I'll just tag a few recent contributors to see if they are interested: @jan-grimo @danielyxyang @brunom @sehe @jcdong98 @andrea-cassioli-maersk @vslashg |
Peter, I assigned you because I assume you know about the super-project CMake business. |
I do work with CMake usually/ |
This looks OK at a first glance, but you should change
to
which checks whether this is the root project (as opposed to checking whether it's part of the Boost superproject.) In principle, Boost libraries are also usable without a superproject, as direct subprojects, although in this specific case this probably isn't very practical because of the number of dependencies. |
Also, if you're going to make changes to CMakeLists.txt, you should first add CI jobs that verify that current uses aren't broken. Or I can add them for you if you prefer. |
If you have some pre-canned test, then yes, please go ahead! |
OK, sure, will do. I see there are some new variables with |
CI jobs for testing CMake subdir/install use added. I arbitrarily picked the |
Actually, I'm a bit confused -- where did you add them to? |
Here: f1e51a0 |
I prefer to use CMake as a build system, but the existing CMake files in Boost don't really help.
I'm always maintaining some split-identity CMake like this in order to do work, so I thought I may as well merge it upstream if